Re: [PATCH 2/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver

[Greg KH]

On Sun, Jul 19, 2026 at 03:53:14AM -0700, Metehan Günen wrote:
> On Sat, Jul 18, 2026 at 11:09:43AM +0200, Greg KH wrote:
> > Why add this extra line?
> > Same here, why the extra line?
> 
> Script artifact — the patch generation script added a spurious blank
> line before both the source and obj entries. Will fix in v2.
> 
> > Please do not roll your own tracing functions, use the in-kernel ones
> > instead.
> 
> Agreed. The entire gxfp_trace module will be removed in v2 and replaced
> with dev_dbg() calls throughout, which integrate with the kernel's
> dynamic debug infrastructure.

Or you can use the normal traceing infrastructure if you really want
trace log messages instead of dev_dbg() ones.  Your call.