Re: [PATCH 2/3] hwmon: (cros_ec) Store the hwmon device in cros_ec_hwmon_priv
From: Guenter Roeck
Date: Sun Jul 19 2026 - 10:35:20 EST
On Sat, Jul 11, 2026 at 11:59:06AM +0200, Thomas Weißschuh wrote:
> The upcoming locking scheme for thermal devices will require access
> to the hwmon device.
>
> Add it do the priv struct.
>
> Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/cros_ec_hwmon.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hwmon/cros_ec_hwmon.c b/drivers/hwmon/cros_ec_hwmon.c
> index f9b19da50472..fb5daa9f80d1 100644
> --- a/drivers/hwmon/cros_ec_hwmon.c
> +++ b/drivers/hwmon/cros_ec_hwmon.c
> @@ -25,6 +25,7 @@
>
> struct cros_ec_hwmon_priv {
> struct cros_ec_device *cros_ec;
> + struct device *hwmon_dev;
> const char *temp_sensor_names[EC_TEMP_SENSOR_ENTRIES + EC_TEMP_SENSOR_B_ENTRIES];
> u8 usable_fans;
> bool fan_control_supported;
> @@ -556,7 +557,6 @@ static int cros_ec_hwmon_probe(struct platform_device *pdev)
> struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
> struct cros_ec_device *cros_ec = ec_dev->ec_dev;
> struct cros_ec_hwmon_priv *priv;
> - struct device *hwmon_dev;
> u8 thermal_version;
> int ret;
>
> @@ -580,10 +580,10 @@ static int cros_ec_hwmon_probe(struct platform_device *pdev)
> priv->temp_threshold_supported = is_cros_ec_cmd_available(priv->cros_ec,
> EC_CMD_THERMAL_GET_THRESHOLD, 1);
>
> - hwmon_dev = devm_hwmon_device_register_with_info(dev, "cros_ec", priv,
> - &cros_ec_hwmon_chip_info, NULL);
> - if (IS_ERR(hwmon_dev))
> - return PTR_ERR(hwmon_dev);
> + priv->hwmon_dev = devm_hwmon_device_register_with_info(dev, "cros_ec", priv,
> + &cros_ec_hwmon_chip_info, NULL);
> + if (IS_ERR(priv->hwmon_dev))
> + return PTR_ERR(priv->hwmon_dev);
>
> cros_ec_hwmon_register_fan_cooling_devices(dev, priv);
>