Re: [RFC PATCH v4 1/3] i2c: rust: implement SMBus read abstraction via kernel::io::Io for I2cClient
From: Muchamad Coirul Anwar
Date: Sun Jul 19 2026 - 11:40:46 EST
On Sat, 18 Jul 2026 at 09:56, Bruce Robertson <brucer42@xxxxxxxxx> wrote:
> For the write side of that rework: I recently posted an RFC with a
> Rust port of the SMB347 charger driver [1], which Igor pointed at this
> series (thanks). I'm dropping my standalone SMBus helpers in favor of
> your Io-based approach.
>
> The SMB347 driver may be a useful early consumer for v5: unlike the
> AS5600 it writes -- a config-unlock write plus read-modify-write
> updates of charge-control register fields -- so it would exercise the
> io_try_write/try_update paths that Igor noted are otherwise easy to
> leave silently infallible. NACK and arbitration loss on a charger
> config write are exactly the failures you don't want reported as
> Ok(()).
>
> Happy to rebase it onto v5 when it's out and report back.
Thanks Bruce. Good to know the SMB347 port can benefit from this too.
The extra write-side coverage would really help, since the AS5600 only
reads. I will CC you on v5.
Coirul