Re: [PATCH v3 1/2] pid: deinline kill_cad_pid

[Oleg Nesterov]

On 07/19, Cen Zhang (Microsoft) wrote:
>
> Move kill_cad_pid() out of the header without changing behavior. This
> prepares for taking a reference to cad_pid under RCU in the following
> fix.

...

> +int kill_cad_pid(int sig, int priv)
> +{
> +	return kill_pid(cad_pid, sig, priv);
> +}

Well... this version doesn't address another comment from sashiko.

Without EXPORT_SYMBOL() this can break the modules which use kill_cad_pid().

Say, drivers/acpi/tiny-power-button.c

I am starting to think that we should apply my patch first, it is more
straightforward. Your 2/2 can be trivially rebased on top of it.

Oleg.