Re: [PATCH 1/2] staging: media: atomisp: Remove unused and unwanted debug module parameters
From: Andy Shevchenko
Date: Sun Jul 19 2026 - 13:05:53 EST
On Sun, Jul 19, 2026 at 5:09 PM Prajval Chaudhary
<prajvalchaudhari733@xxxxxxxxx> wrote:
>
> Remove the unused module parameters 'dbg_level' and 'dbg_func'.
> Additionally, remove the 'pad_w' and 'pad_h' module parameters
> to prevent userspace from overriding internal ISP hardware padding
> boundaries, leaving them as internal driver constants.
>
> This addresses the 'Remove unnecessary/unwanted module parameters'
> task in the driver's TODO file.
So, this patch does the blind removal of the debug parameters. This
driver is in the staging and it is for a reason. Taking this into
account the debug facilities are very useful to have. If you really
would like to help in this area, research how to convert the current
debug facilities to use so-called "trace events" and "trace points".
This is how it should have been done in the Linux kernel.
--
With Best Regards,
Andy Shevchenko