Re: [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst
From: Weijie Yuan
Date: Sun Jul 19 2026 - 13:22:21 EST
On Sun, Jul 19, 2026 at 10:44:52AM -0600, Jonathan Corbet wrote:
> Weijie Yuan <wy@xxxxxxxxx> writes:
>
> > On Sat, Jul 18, 2026 at 04:19:08PM +0100, Yahya Toubali wrote:
> >> Remove trailing spaces on lines 1335 and 2197.
> >>
> >> Signed-off-by: Yahya Toubali <yahya@xxxxxxxxxxxxxxx>
> >
> > Hmmm, for a file that might be modified, I wonder if it makes sense to
> > include fixed line numbers in the commit message. i.e. When the line
> > number changes, your commit message will become meaningless.
> >
> > I'd love to hear others' comments.
>
> Honestly, I question the value of churning the files for a couple of
> trailing blanks in the first place. There are *so many* ways in which
> our documentation can be improved, and this doesn't approach any of
> them.
Yeah, exactly. I even spent some time comparing letter by letter to
figure out exactly where the changes were made, because I didn't
initially read the commit message. ;-)
But I recalled Greg KH's classic email as I've checked this is Yahya's
first contribution known on the list.
https://lwn.net/Articles/658231/
So I was like, okay, first time, let's understand and be inclusive. And
apparently he (or any other pronouns if you prefer) was trying to figure
out how to send his patches out correctly. (I noticed that before this,
his first version of the patches did not even form a series.)
So hopefully Yahya could get familiar with the process soon and start to
make more useful contributions as Jon expected.
But as for whether to accept this or not, I'm afraid I have no answers
or suggestions. (Naturally, there is no authority either.) While
objectively speaking, this patch is indeed rather embarrassing. It's up
to you Jon ;-)
Thanks,
Weijie