Re: [PATCH v4 8/8] iio: adc: ti-ads112c14: add measurement channel support

[Jonathan Cameron]

On Tue, 14 Jul 2026 18:21:30 -0500
"David Lechner (TI)" <dlechner@xxxxxxxxxxxx> wrote:

> Add support for parsing devicetree properties for measurement channels
> and doing direct reads on these.
> 
> There are quite a lot of conditions that have to be met for each
> measurement to be made, so quite a bit of state and algorithms are
> required to handle it.
> 
> Channels are created dynamically since the number of possibilities is
> unreasonably large.
> 
> Signed-off-by: David Lechner (TI) <dlechner@xxxxxxxxxxxx>

Huh. Sashiko had a field day on this one.  Other than the earlier
mentioned 'maybe' case of the i2c_smbus stuff returning short, I'm not
seeing any of the ones I looked at being true. I particular enjoyed the
hold statement that something didn't fit in a 3 bit field.  True, but
the field is 4 bits and there it does fit.

https://sashiko.dev/#/patchset/20260714-iio-adc-ti-ads122c14-v4-0-25f8e3084485%40baylibre.com

To me this all looks good.

Thanks

Jonathan