Re: [PATCH 1/2] dt-bindings: iio: magnetometer: add QST QMC6308

[Jonathan Cameron]

On Tue, 14 Jul 2026 22:28:41 +0200
Jorijn van der Graaf <jorijnvdgraaf@xxxxxxxxxxxxx> wrote:

> Add device tree bindings for the QST QMC6308, a 3-axis AMR
> magnetometer. It is an I2C device in a 4-pin WLCSP package with a
> single supply and no interrupt pin, at I2C address 0x2c.
Hi Jorijn,

As below.  Don't think we care about the package (and manufacturers
often decided to release in more packages if large customers ask for
them). I'm not sure what AMR means, so please spell that out.

A few really minor things below.

> 
> Assisted-by: Claude:claude-fable-5
> Signed-off-by: Jorijn van der Graaf <jorijnvdgraaf@xxxxxxxxxxxxx>

> ---
>  .../iio/magnetometer/qstcorp,qmc6308.yaml     | 48 +++++++++++++++++++
>  MAINTAINERS                                   |  6 +++
>  2 files changed, 54 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/qstcorp,qmc6308.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/qstcorp,qmc6308.yaml b/Documentation/devicetree/bindings/iio/magnetometer/qstcorp,qmc6308.yaml
> new file mode 100644
> index 000000000000..ced839d2aac3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/qstcorp,qmc6308.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/magnetometer/qstcorp,qmc6308.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: QST QMC6308 3-Axis Magnetic Sensor
> +
> +maintainers:
> +  - Jorijn van der Graaf <jorijnvdgraaf@xxxxxxxxxxxxx>
> +
> +description: |
> +  QST QMC6308 3-Axis Magnetic Sensor on I2C bus. The sensor comes in a
> +  4-pin WLCSP package with a single supply and no interrupt pin.

Not sure we care about the package, but the rest is a good description.

> +  https://qstcorp.com/upload/pdf/202202/13-52-15%20QMC6308%20Datasheet%20Rev.%20F(1).pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - qstcorp,qmc6308

Unless you plan to soon add other devices, can use the more compact.
    compatible:
      const: qstcorp,qmc6308