Re: [PATCH v4 1/2] dt-bindings: qcom,snps-dwc3: Add property indicating presence of eUSB2 phy

[Peter Chen]

On 26-07-17 21:34:37, Thinh Nguyen wrote:
> > 
> > Konrad did suggest this on v3:
> > 
> > https://urldefense.com/v3/__https://lore.kernel.org/all/3de365a0-4632-42ea-8a8a-5a4765945a76@xxxxxxxxxxxxxxxx/__;!!A4F2R9G_pg!bFfHVkKIznULZPI2qLzahGobT6OIz4j3-XA_n_3hHnRuvzps_XuAGJdphzxkK4bk6twEah-Zn6xRS1uCQCjZ1ud3HnRftKhw2SXfqA$
> > 
> > This involves cleaning all drivers using these enums if we take that route.
> 
> We should not be using phy_attrs.mode. It's a runtime operation mode.
> 
> Instead, we can introduce a new phy attribute phy_attrs.type and
> phy_get_type(). The phy driver can set this at probe and the dwc3-qcom.c
> can query it from the phy phandle.
> 
> We can define PHY_TYPE_EUSB2 along with the existing types in
> include/dt-bindings/phy/phy.h for this attribute.
> 
> BR,
> Thinh

Good suggestion, Thinh.
Krishna, would you try to do that?

-- 

Thanks,
Peter Chen