RE: [PATCH v3 1/4] dt-bindings: hwmon: (pmbus/max20830): add VOUT feedback resistor properties and complete examples

[Torreno, Alexis Czezar]

> -----Original Message-----
> From: Alexis Czezar Torreno <alexisczezar.torreno@xxxxxxxxxx>
> Sent: Monday, July 20, 2026 11:15 AM
> To: Guenter Roeck <linux@xxxxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>;
> Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>; Jonathan Corbet <corbet@xxxxxxx>; Shuah Khan
> <skhan@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-hwmon@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; Torreno, Alexis Czezar
> <AlexisCzezar.Torreno@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> Subject: [PATCH v3 1/4] dt-bindings: hwmon: (pmbus/max20830): add VOUT
> feedback resistor properties and complete examples
> 
> Add adi,vout-rfb1-ohms and adi,vout-rfb2-ohms properties to support external
> voltage divider configuration for VOUT sensing. When the desired output
> voltage is higher than VREF, a resistor divider (RFB1 and RFB2) is required to
> reach the intended value.
> 
> The properties use a dependency constraint to ensure both resistors are
> specified together, or neither. This prevents misconfiguration where only one
> resistor value is provided.
> 
> This patch also added missing entries in the examples.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@xxxxxxxxxx>
> ---
>  .../bindings/hwmon/pmbus/adi,max20830.yaml           | 20
> ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20830.yaml
> b/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20830.yaml
> index
> 1625dd59417f1b3ca689a9c86ca266da913d1217..214adf1a3b9e9efdeca7db3bd
> 7679c70656e9a7e 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20830.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20830.yaml
> @@ -44,11 +44,26 @@ properties:
>        GPIO connected to the power-good status output pin.
>      maxItems: 1
> 
> +  adi,vout-rfb1-ohms:
> +    description:
> +      Top feedback resistor (RFB1) value in ohms for VOUT sensing divider.
> +      When the desired output voltage is higher than VREF, a resistor divider
> +      is required. VOUT = VREF × (1 + RFB1/RFB2)
> +
> +  adi,vout-rfb2-ohms:
> +    description:
> +      Bottom feedback resistor (RFB2) value in ohms for VOUT sensing divider.
> +      Datasheet recommends that RFB2 does not exceed 2.5kΩ.
> +
>  required:
>    - compatible
>    - reg
>    - vddh-supply
> 
> +dependencies:
> +  adi,vout-rfb1-ohms: ['adi,vout-rfb2-ohms']
> +  adi,vout-rfb2-ohms: ['adi,vout-rfb1-ohms']
> +
>  unevaluatedProperties: false
> 
>  examples:
> @@ -61,6 +76,11 @@ examples:
>              compatible = "adi,max20830";
>              reg = <0x30>;
>              vddh-supply = <&vddh>;
> +            avdd-supply = <&avdd>;
> +            ldoin-supply = <&ldoin>;
> +            pwr-good-gpios = <&gpio 2 GPIO_ACTIVE_HIGH>;
> +            adi,vout-rfb1-ohms = <10000>;
> +            adi,vout-rfb2-ohms = <2000>;
>          };
>      };

Disregard please, I carried over a few info from a dropped patch to combine
with this patch and missed the include for gpio.

Apologies on carrying the review tag, should've removed it even if it was a
small edit.

Regards,
Alexis


>  ...
> 
> --
> 2.34.1