Re: [PATCH 3/3] drivers/perf: hisi: Remove redundant dev_err()/dev_err_probe()

[Yushan Wang]

On 7/17/2026 6:31 PM, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() and dev_err_probe() calls.
>
> Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
> ---
>  drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c | 3 +--
>  drivers/perf/hisilicon/hisi_uncore_pmu.c     | 5 +----
>  2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c b/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c
> index f963e4f9e552..56a88fb0d3c2 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c
> @@ -604,8 +604,7 @@ static int hisi_l3c_pmu_init_ext(struct hisi_pmu *l3c_pmu, struct platform_devic
>  				       IRQF_NOBALANCING | IRQF_NO_THREAD,
>  				       irqname, l3c_pmu);
>  		if (ret < 0)
> -			return dev_err_probe(&pdev->dev, ret,
> -				"Fail to request EXT IRQ: %d.\n", irq);
> +			return ret;
>  
>  		hisi_l3c_pmu->ext_irq[i] = irq;
>  	}
> diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.c b/drivers/perf/hisilicon/hisi_uncore_pmu.c
> index 0ff2fdf4b3e2..77390d033d08 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.c
> @@ -192,11 +192,8 @@ int hisi_uncore_pmu_init_irq(struct hisi_pmu *hisi_pmu,
>  	ret = devm_request_irq(&pdev->dev, irq, hisi_uncore_pmu_isr,
>  			       IRQF_NOBALANCING | IRQF_NO_THREAD,
>  			       dev_name(&pdev->dev), hisi_pmu);
> -	if (ret < 0) {
> -		dev_err(&pdev->dev,
> -			"Fail to request IRQ: %d ret: %d.\n", irq, ret);
> +	if (ret < 0)
>  		return ret;
> -	}
>  
>  	hisi_pmu->irq = irq;
>  
Acked-by: Yushan Wang <wangyushan12@xxxxxxxxxx>

Thanks!