Re: [RFC PATCH v2 7/9] ksmbd: support security.xfstests EAs
From: tanze
Date: Mon Jul 20 2026 - 02:34:18 EST
This is how the current version works, but I believe there is an issue with it. Three days ago, I sent a private email to you and Steve outlining my proposal for improvement, which leverages the SMB3 POSIX extensions to implement this feature. However, your email system blocks messages from me, so I was unable to forward the email to you successfully.
在 2026/7/20 13:03, Namjae Jeon 写道:
diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.cIs it appropriate to special-case an xfstests-only xattr name in ksmbd?
index 2159b45c80a6..da3d5c217577 100644
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -2650,11 +2650,21 @@ static bool ksmbd_is_security_capability_ea_name(const char *name,
!strncmp(name, XATTR_NAME_CAPS, name_len);
}
+static bool ksmbd_is_security_xfstests_ea_name(const char *name,
+ size_t name_len)
+{
+ return name_len == sizeof(XATTR_SECURITY_PREFIX "xfstests") - 1 &&
+ !strncmp(name, XATTR_SECURITY_PREFIX "xfstests", name_len);
Could the security namespace support be implemented using a general,
well-defined policy instead?
Thanks.