Re: [PATCH v2 1/2] drm/panel-edp: fix i2c adapter leak on probe failure
From: Johan Hovold
Date: Mon Jul 20 2026 - 03:51:08 EST
On Fri, Jul 17, 2026 at 10:03:42AM -0700, Doug Anderson wrote:
> > @@ -878,6 +885,11 @@ static int panel_edp_probe(struct device *dev, const struct panel_desc *desc,
> >
> > if (!panel->ddc)
> > return -EPROBE_DEFER;
> > +
> > + err = devm_add_action_or_reset(dev, panel_edp_put_adapter,
> > + panel->ddc);
> > + if (err)
> > + return err;
>
> Yeah, devm makes this so much nicer. Thanks for fixing!
>
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
>
> I'll plan to apply this, probably to drm-misc-next next week. Unless
> someone objects, I won't land it -fixes because it's such a corner
> case.
Sounds good. Thanks.
Johan