Re: [PATCH v2 11/12] misc: Unify style of of_device_id arrays

[Romain Gantois]

Hi Uwe,

On Friday, 17 July 2026 16:50:57 CEST Uwe Kleine-König (The Capable Hub) wrote:
> Update the various of_device_id arrays to conform to the most used and
> 
> generally recommended coding style. That is:
>  - No comma after the list terminator;
>  - A comma after an initializer if (and only if) the closing } is not
>  
>    directly following;
>  
>  - No explicit zeros in the list terminator;
>  - A space after an opening { and before a closing }, a single space in
>  
>    the list terminator;
> 
> Adapt the few offenders accordingly.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub)
> <u.kleine-koenig@xxxxxxxxxxxx> ---
> 
>  drivers/misc/ds1682.c                  | 4 ++--
>  drivers/misc/fastrpc.c                 | 6 +++---
>  drivers/misc/hisi_hikey_usb.c          | 2 +-
>  drivers/misc/lis3lv02d/lis3lv02d_i2c.c | 2 +-
>  drivers/misc/lis3lv02d/lis3lv02d_spi.c | 2 +-
>  drivers/misc/open-dice.c               | 2 +-
>  drivers/misc/pvpanic/pvpanic-mmio.c    | 4 ++--
>  drivers/misc/qcom-coincell.c           | 4 ++--
>  drivers/misc/sram.c                    | 2 +-
>  drivers/misc/ti_fpc202.c               | 2 +-
>  drivers/misc/vcpu_stall_detector.c     | 4 ++--
>  11 files changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/misc/ds1682.c b/drivers/misc/ds1682.c
> index f073a5067fc8..4500d7d0ea77 100644
> --- a/drivers/misc/ds1682.c
> +++ b/drivers/misc/ds1682.c
> @@ -277,8 +277,8 @@ static const struct i2c_device_id ds1682_id[] = {
> 
>  MODULE_DEVICE_TABLE(i2c, ds1682_id);
>  
>  static const struct of_device_id ds1682_of_match[] = {
> 
> -	{ .compatible = "dallas,ds1682", },
> -	{}
> +	{ .compatible = "dallas,ds1682" },
> +	{ }
> 
>  };
>  MODULE_DEVICE_TABLE(of, ds1682_of_match);
> 
> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
> index d86e79134c68..f7b6aba8b71d 100644
> --- a/drivers/misc/fastrpc.c
> +++ b/drivers/misc/fastrpc.c
> @@ -2299,8 +2299,8 @@ static void fastrpc_cb_remove(struct platform_device
> *pdev) }
> 
>  static const struct of_device_id fastrpc_match_table[] = {
> 
> -	{ .compatible = "qcom,fastrpc-compute-cb", },
> -	{}
> +	{ .compatible = "qcom,fastrpc-compute-cb" },
> +	{ }
> 
>  };
>  
>  static struct platform_driver fastrpc_cb_driver = {
> 
> @@ -2579,7 +2579,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device
> *rpdev, void *data, static const struct of_device_id
> fastrpc_rpmsg_of_match[] = {
> 
>  	{ .compatible = "qcom,kaanapali-fastrpc", .data = &kaanapali_soc_data },
>  	{ .compatible = "qcom,fastrpc", .data = &default_soc_data },
> 
> -	{ },
> +	{ }
> 
>  };
>  MODULE_DEVICE_TABLE(of, fastrpc_rpmsg_of_match);
> 
> diff --git a/drivers/misc/hisi_hikey_usb.c b/drivers/misc/hisi_hikey_usb.c
> index 79f06001259b..e68bc6e384d5 100644
> --- a/drivers/misc/hisi_hikey_usb.c
> +++ b/drivers/misc/hisi_hikey_usb.c
> @@ -254,7 +254,7 @@ static void hisi_hikey_usb_remove(struct platform_device
> *pdev)
> 
>  static const struct of_device_id id_table_hisi_hikey_usb[] = {
>  
>  	{ .compatible = "hisilicon,usbhub" },
> 
> -	{}
> +	{ }
> 
>  };
>  MODULE_DEVICE_TABLE(of, id_table_hisi_hikey_usb);
> 
> diff --git a/drivers/misc/lis3lv02d/lis3lv02d_i2c.c
> b/drivers/misc/lis3lv02d/lis3lv02d_i2c.c index 36032fc125f3..7c3ca6d604d1
> 100644
> --- a/drivers/misc/lis3lv02d/lis3lv02d_i2c.c
> +++ b/drivers/misc/lis3lv02d/lis3lv02d_i2c.c
> @@ -95,7 +95,7 @@ static union axis_conversion lis3lv02d_axis_map =
> 
>  #ifdef CONFIG_OF
>  static const struct of_device_id lis3lv02d_i2c_dt_ids[] = {
>  
>  	{ .compatible = "st,lis3lv02d" },
> 
> -	{}
> +	{ }
> 
>  };
>  MODULE_DEVICE_TABLE(of, lis3lv02d_i2c_dt_ids);
>  #endif
> 
> diff --git a/drivers/misc/lis3lv02d/lis3lv02d_spi.c
> b/drivers/misc/lis3lv02d/lis3lv02d_spi.c index 203a108b8883..5bf95176a00e
> 100644
> --- a/drivers/misc/lis3lv02d/lis3lv02d_spi.c
> +++ b/drivers/misc/lis3lv02d/lis3lv02d_spi.c
> @@ -60,7 +60,7 @@ static union axis_conversion lis3lv02d_axis_normal =
> 
>  #ifdef CONFIG_OF
>  static const struct of_device_id lis302dl_spi_dt_ids[] = {
>  
>  	{ .compatible = "st,lis302dl-spi" },
> 
> -	{}
> +	{ }
> 
>  };
>  MODULE_DEVICE_TABLE(of, lis302dl_spi_dt_ids);
>  #endif
> 
> diff --git a/drivers/misc/open-dice.c b/drivers/misc/open-dice.c
> index 45060fb4ea27..77ab0c1e83d3 100644
> --- a/drivers/misc/open-dice.c
> +++ b/drivers/misc/open-dice.c
> @@ -177,7 +177,7 @@ static void open_dice_remove(struct platform_device
> *pdev)
> 
>  static const struct of_device_id open_dice_of_match[] = {
>  
>  	{ .compatible = "google,open-dice" },
> 
> -	{},
> +	{ }
> 
>  };
>  
>  static struct platform_driver open_dice_driver = {
> 
> diff --git a/drivers/misc/pvpanic/pvpanic-mmio.c
> b/drivers/misc/pvpanic/pvpanic-mmio.c index 43a094bfdaec..724dfddf69e4
> 100644
> --- a/drivers/misc/pvpanic/pvpanic-mmio.c
> +++ b/drivers/misc/pvpanic/pvpanic-mmio.c
> @@ -51,8 +51,8 @@ static int pvpanic_mmio_probe(struct platform_device
> *pdev) }
> 
>  static const struct of_device_id pvpanic_mmio_match[] = {
> 
> -	{ .compatible = "qemu,pvpanic-mmio", },
> -	{}
> +	{ .compatible = "qemu,pvpanic-mmio" },
> +	{ }
> 
>  };
>  MODULE_DEVICE_TABLE(of, pvpanic_mmio_match);
> 
> diff --git a/drivers/misc/qcom-coincell.c b/drivers/misc/qcom-coincell.c
> index 3c57f7429147..b58bd34fc471 100644
> --- a/drivers/misc/qcom-coincell.c
> +++ b/drivers/misc/qcom-coincell.c
> @@ -124,8 +124,8 @@ static int qcom_coincell_probe(struct platform_device
> *pdev) }
> 
>  static const struct of_device_id qcom_coincell_match_table[] = {
> 
> -	{ .compatible = "qcom,pm8941-coincell", },
> -	{}
> +	{ .compatible = "qcom,pm8941-coincell" },
> +	{ }
> 
>  };
>  
>  MODULE_DEVICE_TABLE(of, qcom_coincell_match_table);
> 
> diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c
> index 1919d24c8236..c8990e83a65a 100644
> --- a/drivers/misc/sram.c
> +++ b/drivers/misc/sram.c
> @@ -370,7 +370,7 @@ static const struct of_device_id sram_dt_ids[] = {
> 
>  	{ .compatible = "nvidia,tegra186-sysram", .data = &tegra_sysram_config },
>  	{ .compatible = "nvidia,tegra194-sysram", .data = &tegra_sysram_config },
>  	{ .compatible = "nvidia,tegra234-sysram", .data = &tegra_sysram_config },
> 
> -	{}
> +	{ }
> 
>  };
>  
>  static int sram_probe(struct platform_device *pdev)
> 
> diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c
> index 2aac83ec4a39..9e2d24f89457 100644
> --- a/drivers/misc/ti_fpc202.c
> +++ b/drivers/misc/ti_fpc202.c
> @@ -718,7 +718,7 @@ static void fpc202_remove(struct i2c_client *client)
> 
>  static const struct of_device_id fpc202_of_match[] = {
>  
>  	{ .compatible = "ti,fpc202" },
> 
> -	{}
> +	{ }
> 
>  };
>  MODULE_DEVICE_TABLE(of, fpc202_of_match);
> 
> diff --git a/drivers/misc/vcpu_stall_detector.c
> b/drivers/misc/vcpu_stall_detector.c index 26166357b255..1306b2c1ef99
> 100644
> --- a/drivers/misc/vcpu_stall_detector.c
> +++ b/drivers/misc/vcpu_stall_detector.c
> @@ -224,8 +224,8 @@ static void vcpu_stall_detect_remove(struct
> platform_device *pdev) }
> 
>  static const struct of_device_id vcpu_stall_detect_of_match[] = {
> 
> -	{ .compatible = "qemu,vcpu-stall-detector", },
> -	{}
> +	{ .compatible = "qemu,vcpu-stall-detector" },
> +	{ }
> 
>  };
>  
>  MODULE_DEVICE_TABLE(of, vcpu_stall_detect_of_match);

Reviewed-by: Romain Gantois <romain.gantois@xxxxxxxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part.