Re: [PATCH net-next 1/5] bridge: Use direct pointer in br_is_nd_neigh_msg()

[Nikolay Aleksandrov]

On 19/07/2026 16:34, Danielle Ratson wrote:
> Both callers of br_is_nd_neigh_msg() already call pskb_may_pull() to
> ensure sizeof(struct ipv6hdr) + sizeof(struct nd_msg) bytes are in the
> linear area before invoking this function. The skb_header_pointer()
> call and its fallback buffer are therefore unnecessary.
>
> Replace skb_header_pointer() with a direct cast to ipv6_hdr(skb) + 1
> and drop the now-unused 'msg' parameter and its corresponding stack
> buffer from all callers.
>
> Reviewed-by: Petr Machata <petrm@xxxxxxxxxx>
> Signed-off-by: Danielle Ratson <danieller@xxxxxxxxxx>
> ---
>   net/bridge/br_arp_nd_proxy.c | 9 ++-------
>   net/bridge/br_device.c       | 4 ++--
>   net/bridge/br_input.c        | 4 ++--
>   net/bridge/br_private.h      | 2 +-
>   4 files changed, 7 insertions(+), 12 deletions(-)

Acked-by: Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>