Re: [PATCH 1/3] Bluetooth: hci_qca: Replace HCI_VENDOR_PKT usage with HCI_EV_VENDOR

[Bartosz Golaszewski]

On Sat, 18 Jul 2026 00:08:53 +0200, Zijun Hu <zijun.hu@xxxxxxxxxxxxxxxx> said:
> The macros below have different meanings even though they share the
> same value 0xff:
>
>   HCI_VENDOR_PKT: HCI packet indicator or type
>   HCI_EV_VENDOR:  event code of a VSE
>
> This usage of HCI_VENDOR_PKT is wrongly checking an event code.
>
> Fix by using HCI_EV_VENDOR for event code.
> Also fix warning "CHECK: Unnecessary parentheses around comparison"
> given by checkpatch.pl.
>
> Signed-off-by: Zijun Hu <zijun.hu@xxxxxxxxxxxxxxxx>
> ---
>  drivers/bluetooth/hci_qca.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index bd29d422c209..f978087612ee 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -1240,8 +1240,8 @@ static int qca_recv_event(struct hci_dev *hdev, struct sk_buff *skb)
>  	 * received we store dump into a file before closing hci. This
>  	 * dump will help in triaging the issues.
>  	 */
> -	if ((skb->data[0] == HCI_VENDOR_PKT) &&
> -	    (get_unaligned_be16(skb->data + 2) == QCA_SSR_DUMP_HANDLE))
> +	if (skb->data[0] == HCI_EV_VENDOR &&
> +	    get_unaligned_be16(skb->data + 2) == QCA_SSR_DUMP_HANDLE)
>  		return qca_controller_memdump_event(hdev, skb);
>
>  	return hci_recv_frame(hdev, skb);
>
> --
> 2.34.1
>
>

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>