Re: [PATCH] arm64: dts: qcom: sm8150: Add slim nodes

[Konrad Dybcio]

On 7/20/26 11:33 AM, XiaoYeZi wrote:
> The slimbus node is an important node in audio.

That is true, but this is not a great commit message. Please
check out:

https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

[...]

> +		slimbam: dma-controller@17184000 {
> +			compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
> +			qcom,controlled-remotely;
> +			reg = <0 0x17184000 0 0x2c000>;
> +			num-channels = <31>;
> +			interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
> +			#dma-cells = <1>;
> +			qcom,ee = <1>;
> +			qcom,num-ees = <2>;
> +			iommus = <&apps_smmu 0x1b46 0x0>;

Please assign the iommus values as the downstream kernel does, so
that all SIDs meant for the OS are assigned

Konrad