Re: [PATCH 3/4] iio: dac: ad5686: extend device support with new parts

[Rodrigo Alencar]

On 19/07/26 22:43, Jonathan Cameron wrote:
> On Sun, 19 Jul 2026 10:51:59 +0100
> Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@xxxxxxxxxx> wrote:
> 
> > From: Rodrigo Alencar <rodrigo.alencar@xxxxxxxxxx>
> > 
> > Add support for AD5313R, AD5317R, AD5674, AD5679, AD5687, AD5687R, AD5689,
> > AD5689R to the AD5686 SPI driver. Also adding support for AD5316R, AD5675,
> > AD5697R to the AD5696 I2C driver. AD5673R and AD5677R were missing from
> > the of_match table.
> 
> Given I'm asking for a v2 anyway, please break out the missing of_match
> table entries as a precursor.

checkpatch complains adding stuff to of_match table without having the entry in
the dt-binding. I suppose the desired order for the changes would be:

clean ups:

- ad5696 dt-binding: adding support for the 'missing' entries.
- ad5696-i2c: add missing of_match entries
- Adjust reformat device list in file-comment headers and Kconfig

extend dev support:

- ad5686 dt-binding changes (new devices)
- ad5696 dt-binding changes (new devices)
- create new chip info's and populated device tables
- Add new devices to Kconfig option description

Does it sound reasonable?

-- 
Kind regards,

Rodrigo Alencar