Re: [PATCH v3] staging: media: atomisp: Remove pad_w and pad_h module parameters

[Andy Shevchenko]

On Mon, Jul 20, 2026 at 04:58:07PM +0530, Prajval Chaudhary wrote:
> Hi Andy, Dan, Hans,
> 
> Thank you for the review and catching this. 
> 
> In this v3, I have completely dropped the changes to the debug 
> parameters to keep the staging debug facilities fully intact as requested.
> 
> This patch now strictly focuses on removing the 'pad_w' and 'pad_h' 
> module parameters and converting them into internal driver constants.

This must not be the part of the commit message. See below.

> Remove the 'pad_w' and 'pad_h' module parameters to prevent userspace
> from overriding internal ISP hardware padding boundaries. Convert them
> into internal driver constants instead.
> 
> This partially addresses the 'Remove unnecessary/unwanted module
> parameters' task in the driver's TODO file, while keeping the debug
> facilities intact as requested by maintainers.

If it partially addresses, then I recommend to finish the task.
Half-baked solutions usually are not welcome (only as a discussion
starter or so). I already told that the whole debug facility in
this driver should be aligned with the kernel APIs and tools.
Have you read my previous replies?

> Signed-off-by: Prajval Chaudhary <prajvalchaudhari733@xxxxxxxxx>
> ---

Here is the space to add comments like you put in the above text.

>  drivers/staging/media/atomisp/pci/atomisp_common.h | 4 ++--
>  drivers/staging/media/atomisp/pci/atomisp_v4l2.c   | 8 ++------

-- 
With Best Regards,
Andy Shevchenko