Re: [PATCH] mount: remove redundant panic() in mnt_init()

[Jori Koolstra]

On Mon, Jul 20, 2026 at 07:23:31AM -0400, Hamza Mahfooz wrote:
> Since at least as far back as commit 0818bf27c05b ("resizable
> namespace.c hashes"), we call alloc_large_system_hash() in
> mnt_init() which already panics if the table is NULL.
> 
> Signed-off-by: Hamza Mahfooz <hamzamahfooz@xxxxxxxxxxxxxxxxxxx>
> ---
>  fs/namespace.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/namespace.c b/fs/namespace.c
> index fe919abd2f01..43de01ce023e 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -6248,9 +6248,6 @@ void __init mnt_init(void)
>  				HASH_ZERO,
>  				&mp_hash_shift, &mp_hash_mask, 0, 0);
>  
> -	if (!mount_hashtable || !mountpoint_hashtable)
> -		panic("Failed to allocate mount hash table\n");
> -
>  	kernfs_init();
>  
>  	err = sysfs_init();
> -- 
> 2.55.0
> 

There isn't a reasonable way to return from this, and I see the other
uses of alloc_large_system_hash() also don't check for NULL, so this
is an OK clean-up.

Reviewed-by: Jori Koolstra <jkoolstra@xxxxxxxxx>