Re: [PATCH] drm/panel: fix unmet dependency bug for DRM_PANEL_HIMAX_HX83121A

[neil . armstrong]

On 7/12/26 01:42, Julian Braha wrote:
> Currently, DRM_PANEL_HIMAX_HX83121A selects DRM_DISPLAY_DSC_HELPER
> without also ensuring DRM_DISPLAY_HELPER is enabled, causing an unmet
> dependency:
>
> WARNING: unmet direct dependencies detected for DRM_DISPLAY_DSC_HELPER
>    Depends on [n]: HAS_IOMEM [=y] && DRM [=m] && DRM_DISPLAY_HELPER [=n]
>    Selected by [m]:
>    - DRM_PANEL_HIMAX_HX83121A [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_PANEL [=y] && OF [=y] && DRM_MIPI_DSI [=y] && BACKLIGHT_CLASS_DEVICE [=m]
>    - DRM_PANEL_ILITEK_ILI9882T [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_PANEL [=y] && OF [=y] && DRM_MIPI_DSI [=y] && BACKLIGHT_CLASS_DEVICE [=m]
>
> Many other DRM_PANEL_* options select DRM_DISPLAY_HELPER when selecting
> DRM_DISPLAY_DSC_HELPER, let's do the same here.
>
> This unmet dependency bug was found by kconfirm, a static analysis tool
> for Kconfig.
>
> Fixes: defab7b01e08 ("drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER")
> Signed-off-by: Julian Braha <julianbraha@xxxxxxxxx>
> ---
>   drivers/gpu/drm/panel/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index cfbfb371bc67..06bfcef35a72 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -253,6 +253,7 @@ config DRM_PANEL_HIMAX_HX83121A
>   	depends on OF
>   	depends on DRM_MIPI_DSI
>   	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_DISPLAY_HELPER
>   	select DRM_DISPLAY_DSC_HELPER
>   	select DRM_KMS_HELPER
>   	help

Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>

Thanks,
Neil