Re: [PATCH 1/3] dt-bindings: nvmem: mediatek: efuse: add mt6572

[AngeloGioacchino Del Regno]

On 7/15/26 16:27, Roman Vivchar via B4 Relay wrote:
> From: Roman Vivchar <rva333@xxxxxxxxxxxxxx>
>
> Add a compatible string for the mt6572 SoC efuse controller.

Please, avoid adding this to the list of compatibles that need you do specify

"mediatek,mt6572-efuse", "mediatek,efuse";

The "generic" compatible should disappear.. and plus, the MT6572 SoC seems to
be pretty special, as you had to implement aligned read just for that.

This won't be the only SoC as well, as probably all of the legacy one from the
same era will be affected... so please, add it as a const so that you can have
a devicetree with an efuse node declaring

compatible = "mediatek,mt6572-efuse";

Cheers,
Angelo

> Signed-off-by: Roman Vivchar <rva333@xxxxxxxxxxxxxx>
> ---
>   Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> index f9323b3ecfc8..269e2b09f5c8 100644
> --- a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> @@ -44,6 +44,7 @@ properties:
>   
>         - items:
>             - enum:
> +              - mediatek,mt6572-efuse
>                 - mediatek,mt7622-efuse
>                 - mediatek,mt7623-efuse
>                 - mediatek,mt7981-efuse