Re: [PATCH v2 1/7] dt-bindings: reset: Add MT6589 toprgu reset IDs

[AngeloGioacchino Del Regno]

On 7/20/26 08:25, Krzysztof Kozlowski wrote:
> On Fri, Jul 17, 2026 at 06:39:12PM +0200, Luca Leonardo Scorcia wrote:
> > Add reset constants for the 12 MT6589 toprgu resets.
>
>
> This is not a single-patch patchset. Seven patches.
>
> So one posting per 24h, so we actually have a possibility to review it.

krzk, that's because Sashiko provides reviews instantly, and people just go and
fix things to make it easier on us maintainers to provide reviews (and avoiding
to see the same Sashiko complaints from us).

That said, this gets into personal preference territory, and I'm not trying to
start any conversation about that specifically...

> > Signed-off-by: Luca Leonardo Scorcia <l.scorcia@xxxxxxxxx>
> > ---
> >   .../reset/mediatek,mt6589-resets.h            | 24 +++++++++++++++++++
> >   1 file changed, 24 insertions(+)
> >   create mode 100644 include/dt-bindings/reset/mediatek,mt6589-resets.h
> >
> > diff --git a/include/dt-bindings/reset/mediatek,mt6589-resets.h b/include/dt-bindings/reset/mediatek,mt6589-resets.h
> > new file mode 100644
> > index 000000000000..ee08c39df513
> > --- /dev/null
> > +++ b/include/dt-bindings/reset/mediatek,mt6589-resets.h
>
>
> Why is this header being added outside of patch documenting compatible?
> You have entire commit msg to say something useful instead of repeating
> the subject.

Because he wrote it all in the cover letter... which is something that gets
read right now, but gets lost once the commits are picked - so all context and
explaining are completely lost.

Luca, that's why krzk is complaining :-)

Just write the information in each commit's description, so that it doesn't get
lost, and so that the next one trying to understand what went on with the toprgu
can just read it there. :-)

Cheers,
Angelo