Re: [Patch net-next v3] net: phy: Add driver for Motorcomm Quad 2.5GbE phy

[Andrew Lunn]

> >> -static struct phy_driver motorcomm_phy_drvs[] = {
> >> -	{
> >> -		PHY_ID_MATCH_EXACT(PHY_ID_YT8511),
> >> -		.name		= "YT8511 Gigabit Ethernet",
> >> -		.config_init	= yt8511_config_init,
> >> -		.suspend	= genphy_suspend,
> >> -		.resume		= genphy_resume,
> >> -		.read_page	= yt8511_read_page,
> >> -		.write_page	= yt8511_write_page,
> >> -	},
> > 
> > I still don't like this. Please stop diff deleting all these and
> > putting them back later. It makes me thing something changed, maybe
> > white space?
> 
> Ans: I tried to refactor this issue by hanging the position of the newly
> added code. However, the same issue may still arise in other code segments, 
> without modifying the existing code.

Look at other patches on this list. Look at the diff generated. Do you
see the same sort of issue? I'm pretty sure something is wrong here.

Try

git reset HEAD~1
git diff -w

and see if you get a different diff. That would indicate there is a
whitespace change you need to revert.

	   Andrew