Re: [PATCH net-next v4] net: phy: Add driver for Motorcomm Quad 2.5GbE phy

[Andrew Lunn]

On Mon, Jul 20, 2026 at 05:11:33PM +0800, Kyle Switch wrote:
> Add a driver for motorcomm yt8824 quad 2.5G ethernet phy, supports
> 2.5G/1000M/100M/10M speed.

So this is better, however still not correct.

> -		/* Enable WOL feature */
> -		mask = YTPHY_WCR_PULSE_WIDTH_MASK | YTPHY_WCR_INTR_SEL;
> -		val = YTPHY_WCR_ENABLE | YTPHY_WCR_INTR_SEL;
> -		val |= YTPHY_WCR_TYPE_PULSE | YTPHY_WCR_PULSE_WIDTH_672MS;
> -		ret = ytphy_modify_ext(phydev, YTPHY_WOL_CONFIG_REG, mask, val);
> +		/* Enable WOL feature */
> +		mask = YTPHY_WCR_PULSE_WIDTH_MASK | YTPHY_WCR_INTR_SEL;
> +		val = YTPHY_WCR_ENABLE | YTPHY_WCR_INTR_SEL;
> +		val |= YTPHY_WCR_TYPE_PULSE | YTPHY_WCR_PULSE_WIDTH_672MS;
> +		ret = ytphy_modify_ext(phydev, YTPHY_WOL_CONFIG_REG, mask, val);

Look at these lines. What changed?

As a reviewer, i review diffs. Changes like this are just a waste of
my time. Please review your own diffs, look for issues like this,
solve them. I won't give comments on the actual code until these
problems are gone.

    Andrew

---
pw-bot: cr