Re: [PATCH v2] EDAC/altera: Fix device node reference leaks in the SDMMC ECC setup

[Dinh Nguyen]

On 7/17/26 08:17, Rounak Das wrote:
> Under altr_portb_setup() and socfpga_init_sdmmc_ecc(),
> of_find_compatible_node() was being used to look up the sdmmc-ecc
> node. This node wasn't being dropped using of_node_put().
>
> altr_portb_setup() did not drop its reference under its success path
> or on any error path.
>
> socfpga_init_sdmmc_ecc() did an early return thereby skipping the
> common exit label and thus leaking the reference.
>
> Add the missing of_node_put() calls in altr_portb_setup(), and route
> socfpga_init_sdmmc_ecc()'s success path through the common exit label.
>
> Fixes: 911049845d70 ("EDAC, altera: Add Arria10 SD-MMC EDAC support")
> Fixes: 788586efd116 ("EDAC/altera: Initialize peripheral FIFOs in probe()")
> Cc: stable@xxxxxxxxxxxxxxx
> Closes: https://sashiko.dev/#/patchset/20260708091135.94114-1-rounakdas2025%40gmail.com
> Signed-off-by: Rounak Das <rounakdas2025@xxxxxxxxx>
> ---

Acked-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>