Re: [PATCH 1/3] usb: chipidea: Use %pe to print error pointers

[Frank Li]

On Sun, Jul 19, 2026 at 06:25:46PM +0530, Subasri S wrote:
>
> Use the %pe format specifier instead of %ld with PTR_ERR() for printing
> error pointers in imx_get_clks(), ci_hdrc_imx_probe(), and
> ci_get_platdata(). This prints symbolic error names (e.g. -ENOMEM)
> instead of errno numbers (e.g. -12), making error logs more readable.
>
> This patch fixes coccinelle reported warnings:

Avoid use words "This patch", just

Fix coccinelle reported warnings:

> ./chipidea/ci_hdrc_imx.c:452:5-12: WARNING: Consider using %pe to print PTR_ERR()
> ./chipidea/ci_hdrc_imx.c:468:5-12: WARNING: Consider using %pe to print PTR_ERR()
> ./chipidea/ci_hdrc_imx.c:222:4-11: WARNING: Consider using %pe to print PTR_ERR()
> ./chipidea/ci_hdrc_imx.c:222:24-31: WARNING: Consider using %pe to print PTR_ERR()

keep one is enough

> ./chipidea/core.c:684:4-11: WARNING: Consider using %pe to print PTR_ERR()
>
> Compile-tested only.
>
> Signed-off-by: Subasri S <subasris1210@xxxxxxxxx>
> ---
>  drivers/usb/chipidea/ci_hdrc_imx.c | 12 ++++++------
>  drivers/usb/chipidea/core.c        |  4 ++--
>  2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index 56d2ba824a0b..7bfe37ed68ae 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -218,8 +218,8 @@ static int imx_get_clks(struct device *dev)
>                 if (IS_ERR(data->clk)) {
>                         ret = PTR_ERR(data->clk);
>                         dev_err(dev,
> -                               "Failed to get clks, err=%ld,%ld\n",
> -                               PTR_ERR(data->clk), PTR_ERR(data->clk_ipg));
> +                               "Failed to get clks, err=%pe,%pe\n",
> +                               data->clk, data->clk_ipg);
>                         return ret;
>                 }
>                 /* Get wakeup clock. Not all of the platforms need to
> @@ -448,8 +448,8 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
>                 pinctrl_hsic_idle = pinctrl_lookup_state(data->pinctrl, "idle");
>                 if (IS_ERR(pinctrl_hsic_idle)) {
>                         dev_err(dev,
> -                               "pinctrl_hsic_idle lookup failed, err=%ld\n",
> -                                       PTR_ERR(pinctrl_hsic_idle));
> +                               "pinctrl_hsic_idle lookup failed, err=%pe\n",
> +                                       pinctrl_hsic_idle);
>                         ret = PTR_ERR(pinctrl_hsic_idle);
>                         goto err_put;
>                 }
> @@ -464,8 +464,8 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
>                                                                 "active");
>                 if (IS_ERR(data->pinctrl_hsic_active)) {
>                         dev_err(dev,
> -                               "pinctrl_hsic_active lookup failed, err=%ld\n",
> -                                       PTR_ERR(data->pinctrl_hsic_active));
> +                               "pinctrl_hsic_active lookup failed, err=%pe\n",
> +                                       data->pinctrl_hsic_active);
>                         ret = PTR_ERR(data->pinctrl_hsic_active);
>                         goto err_put;
>                 }
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 07563be0013f..09db8a4eace2 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -680,8 +680,8 @@ static int ci_get_platdata(struct device *dev,
>                         /* no vbus regulator is needed */
>                         platdata->reg_vbus = NULL;
>                 } else if (IS_ERR(platdata->reg_vbus)) {
> -                       dev_err(dev, "Getting regulator error: %ld\n",
> -                               PTR_ERR(platdata->reg_vbus));
> +                       dev_err(dev, "Getting regulator error: %pe\n",
> +                               platdata->reg_vbus);
>                         return PTR_ERR(platdata->reg_vbus);
>                 }
>                 /* Get TPL support */
>
> --
> 2.43.0
>
>