Re: [PATCH 6/7] soc: ti: wkup_m3_ipc: Remove redundant dev_err()

[Hari Prasath G E]

On 7/20/2026 3:29 PM, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.

Thanks for the patch

Reviewed-by: Hari Prasath Gujulan Elango <gehariprasath@xxxxxx>

> Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
> ---
>   drivers/soc/ti/wkup_m3_ipc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 5845fc652adc..f8640cdc2a21 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -630,10 +630,8 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
>   
>   	ret = devm_request_irq(dev, irq, wkup_m3_txev_handler,
>   			       0, "wkup_m3_txev", m3_ipc);
> -	if (ret) {
> -		dev_err(dev, "request_irq failed\n");
> +	if (ret)
>   		return ret;
> -	}
>   
>   	m3_ipc->mbox_client.dev = dev;
>   	m3_ipc->mbox_client.tx_done = NULL;