Re: [PATCH v3 1/2] pid: deinline kill_cad_pid

[Oleg Nesterov]

On 07/20, Oleg Nesterov wrote:
>
> On 07/20, Eric W. Biederman wrote:
> >
> > "Cen Zhang (Microsoft)" <blbllhy@xxxxxxxxx> writes:
> >
> > > Move kill_cad_pid() out of the header without changing behavior. This
> > > prepares for taking a reference to cad_pid under RCU in the following
> > > fix.
> >
> > nit: If you are going to uninline kill_cad_pid should be placed in
> > signal.c not in pid.c
> >
> > That is where everything else that sends signals lives.
>
> Agreed, but...
>
> I had a private discussion with Alexey. And he pointed out that if
> we move kill_cad_pid() to reboot.c we are almost ready to unexport
> cad_pid and make it static.
>
> The only problem is kernel_init_freeable(). but I guess we can shift
> the cad_pid initialization to reboot_ksysfs_init().
>
> Anyway, this needs another patch. So I agree with signal.c in 1/2.

Forgot to mention... Either way 1/2 can remove EXPORT_SYMBOL(cad_pid)
but it has to add EXPORT_SYMBOL(kill_cad_pid).

Oleg.