Re: [PATCH 04/31] swim: Don't disable drive after every sector

[Laurent Vivier]

Le 16/07/2026 à 12:02, Finn Thain a écrit :
> This fixes multi-sector reads on a Sony drive. The Mitsubishi drive
> doesn't seem to care either way.
>
> Fixes: 8852ecd97488 ("m68k: mac - Add SWIM floppy support")
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxx>
> ---
>   drivers/block/swim.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/block/swim.c b/drivers/block/swim.c
> index 2a400e544959..f9c59282b81f 100644
> --- a/drivers/block/swim.c
> +++ b/drivers/block/swim.c
> @@ -473,8 +473,6 @@ static inline int swim_read_sector(struct floppy_state *fs,
>   	short i;
>   
>   	swim_track(fs, track);
> -
> -	swim_write(base, mode1, MOTON);
>   	swim_head(base, side);
>   	swim_write(base, mode0, side);
>   
> @@ -490,8 +488,6 @@ static inline int swim_read_sector(struct floppy_state *fs,
>   	}
>   	local_irq_restore(flags);
>   
> -	swim_write(base, mode0, MOTON);
> -
>   	if ((header.side != side)  || (header.track != track) ||
>   	     (header.sector != sector))
>   		return 0;

Reviewed-by: Laurent Vivier <laurent@xxxxxxxxx>