Re: [PATCH] x86/apic: Ensure ICR register write value is handled as 32 bits

[Thomas Gleixner]

On Wed, Jul 08 2026 at 01:21, Melody Wang wrote:
> The low 32-bit ICR data is prepared by __prepare_ICR(), which returns
> a 32-bit value. However, when this value is assigned to a new variable,
> it's easy to mistakenly declare that variable with a different width.
>
> To avoid this class of mistakes, use __prepare_ICR() directly as the
> function argument instead of storing its result in an intermediate
> variable. This also shaves off a bunch of lines in the code.
>
> There should be no functionality change resulting from this patch.
>
> Signed-off-by: Melody Wang <huibo.wang@xxxxxxx>

Acked-by: Thomas Gleixner <tglx@xxxxxxxxxx>