Re: [PATCH v2 1/3] drm/bridge: Use named initializers for arrays of i2c_device_data
From: Doug Anderson
Date: Mon Jul 20 2026 - 15:30:54 EST
Hi,
On Mon, Jul 20, 2026 at 4:26 AM Uwe Kleine-König (The Capable Hub)
<u.kleine-koenig@xxxxxxxxxxxx> wrote:
>
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
>
> The mentioned robustness is relevant for a planned change to struct
> i2c_device_id that replaces .driver_data by an anonymous union.
>
> While touching all these arrays, unify usage of whitespace in the list
> terminator and drop trailing commas there.
>
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits. The former was confirmed with x86 and arm64
> builds.
>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 10 +++++-----
> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 2 +-
> drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++--
> drivers/gpu/drm/bridge/chipone-icn6211.c | 4 ++--
> drivers/gpu/drm/bridge/chrontel-ch7033.c | 2 +-
> drivers/gpu/drm/bridge/ite-it6263.c | 2 +-
> drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
> drivers/gpu/drm/bridge/lontium-lt8713sx.c | 2 +-
> drivers/gpu/drm/bridge/lontium-lt8912b.c | 4 ++--
> drivers/gpu/drm/bridge/lontium-lt9211.c | 4 ++--
> drivers/gpu/drm/bridge/lontium-lt9611.c | 4 ++--
> drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
> .../gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 8 ++++----
> drivers/gpu/drm/bridge/nxp-ptn3460.c | 4 ++--
> drivers/gpu/drm/bridge/parade-ps8622.c | 8 ++++----
> drivers/gpu/drm/bridge/sii902x.c | 2 +-
> drivers/gpu/drm/bridge/sii9234.c | 2 +-
> drivers/gpu/drm/bridge/sil-sii8620.c | 2 +-
> drivers/gpu/drm/bridge/tc358767.c | 2 +-
> drivers/gpu/drm/bridge/tc358768.c | 4 ++--
> drivers/gpu/drm/bridge/tc358775.c | 4 ++--
> drivers/gpu/drm/bridge/tda998x_drv.c | 2 +-
> drivers/gpu/drm/bridge/ti-dlpc3433.c | 2 +-
> drivers/gpu/drm/bridge/ti-sn65dsi83.c | 6 +++---
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++--
> drivers/gpu/drm/bridge/ti-tfp410.c | 2 +-
> 26 files changed, 47 insertions(+), 47 deletions(-)
Acked-by: Douglas Anderson <dianders@xxxxxxxxxxxx> # ti-sn65dsi86.c