Re: [PATCH 0/8] mm/khugepaged: collapse_file() cleanups
From: Pedro Falcato
Date: Mon Jul 20 2026 - 16:05:56 EST
On Mon, Jul 20, 2026 at 09:21:11AM -0600, Nico Pache wrote:
> On Mon, Jul 20, 2026 at 8:33 AM Pedro Falcato <pfalcato@xxxxxxx> wrote:
> >
> > Here are a bunch of cleanups for collapse_file() that attempt to aid
> > code readability and understanding. This is part 1 out of N, and only
> > attempts to address the main collapse loop. The exit path is still a
> > mess but I figure it's much easier to review if I send this batch as-is,
> > versus sending the whole thing.
>
> Hi Pedro,
>
> I have already prepped a cleanup series for collapse_file().
>
> I was waiting for my work here
> https://lore.kernel.org/lkml/20260715025941.1571316-1-npache@xxxxxxxxxx/
> to be reviewed (and in mm-unstable) before sending it out.
>
> Our series have several similarities; for reference, here is my version.
> https://gitlab.com/npache/linux/-/commits/khugepaged_file_refactor?ref_type=heads
Ugh, this is awkward. Do you have any suggestions on next steps?
I can try and take in some of your work on top of this series. But that might
be hairy.
This situation really does suck (I've definitely been there), but I would
prefer not to drop the patchset.
--
Pedro