Re: [PATCH v5 0/7] dtc: dt-check-style: Improvement after using on DTS
From: Rob Herring
Date: Mon Jul 20 2026 - 16:52:08 EST
On Thu, Jul 09, 2026 at 07:41:28PM +0200, Krzysztof Kozlowski wrote:
> Changes in v5:
> 1. Patch #2, dtc: dt-check-style: Allow space-aligning indentation in
> DTS:
> Handle also line continuations for properties.
> 2. Update docs, other minor style/docs comments from Sashiko
> - Link to v4: https://patch.msgid.link/20260708-dts-style-checker-v4-0-c175e6401150@xxxxxxxxxxxxxxxx
>
> Changes in v4:
> 1. Drop patch:
> "dtc: dt-check-style: Do not sort top-level nodes in DTS by unit address"
> This needs more work.
> 2. Patch #1: Rename rule tab-in-dts to tab-in-yaml
> 3. Drop "memory@a0000000" in examples, because it messes with top-level
> sorting. Use a "cpus" node to test node and device_type property ordering.
> 4. Add more test-cases: within existing commits and a new patch at the
> end:
> "dtc: dt-check-style: Add more DTS test cases"
> 5. Handle #include and /include/ without trailing space
>
> Link to v3: https://patch.msgid.link/20260706-dts-style-checker-v3-0-03ffacff9226@xxxxxxxxxxxxxxxx
>
> Changes in v3:
> 1. Patch #2: Use re.search
> 2. Patch #2: Add dts-mixed-indent.dts test case
> 3. Several new patches 3-7.
> v2: https://lore.kernel.org/r/20260706102421.343639-4-krzysztof.kozlowski@xxxxxxxxxxxxxxxx/
>
> Changes in v2:
> 1. Patch #2: Rework idea.
> 2. Adjust function doc/comment.
> v1: https://lore.kernel.org/r/20260706071446.87669-2-krzysztof.kozlowski@xxxxxxxxxxxxxxxx/
>
> (I was not using b4 for v1 and v2, so b4 diff might fail)
>
> Best regards,
> Krzysztof
>
> ---
> Krzysztof Kozlowski (7):
> dtc: dt-check-style: Narrow disallowing of tab in DTS only to YAML
> dtc: dt-check-style: Allow space-aligning indentation in DTS
> dtc: dt-check-style: Rework handling YAML/DTS in rules
> dtc: dt-check-style: Expect first device_type
> dtc: dt-check-style: Handle properly DTC-style includes
> dtc: dt-check-style: Print proper line number of indentation detection place
> dtc: dt-check-style: Add more DTS test cases
Applied. Send a follow-up if the sashiko report is valid.
Rob