Re: [PATCH] dt-bindings: clock: ti,da850-pll: Convert to DT schema

From: David Lechner

Date: Mon Jul 20 2026 - 18:11:59 EST


On 7/17/26 1:21 PM, Bhargav Joshi wrote:
> Convert TI da850-pll binding from legacy text to dt schema.
> No functional change is introduced during conversion.
>
> Signed-off-by: Bhargav Joshi <j.bhargav.u@xxxxxxxxx>
> ---

...

> diff --git a/Documentation/devicetree/bindings/clock/ti/davinci/ti,da850-pll.yaml b/Documentation/devicetree/bindings/clock/ti/davinci/ti,da850-pll.yaml
> new file mode 100644
> index 000000000000..5e4109567b75
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/ti/davinci/ti,da850-pll.yaml
> @@ -0,0 +1,177 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/ti/davinci/ti,da850-pll.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI DaVinci PLL Controllers

TI DA850/OMAP-L138/AM18xx PLL Controllers

(The original binding used to have more, but they have since been removed
because of obsolescence. We don't expect to ever add more.)

> +
> +maintainers:
> + - David Lechner <david@xxxxxxxxxxxxxx>
> + - Bhargav Joshi <j.bhargav.u@xxxxxxxxx>

Do you actually have knowledge/interest/hardware needed to
support this?

> +
> +description:
> + The PLL provides clocks to most of the components on the SoC. In addition to
> + the PLL itself, this controller also contains bypasses, gates, dividers, an
> + multiplexers for various clock signals.
> +
> +properties:
> + compatible:
> + enum:
> + - ti,da850-pll0
> + - ti,da850-pll1
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + minItems: 1
> + maxItems: 2
> +
> + clock-names:
> + minItems: 1
> + maxItems: 2

The items: needs to be moved up here. The if: should only limit pll1.