Re: [PATCH] ata: pata_ep93xx: add missing "cc" clobber to inline asm

From: Damien Le Moal

Date: Mon Jul 20 2026 - 19:02:44 EST


On 7/21/26 06:09, Rosen Penev wrote:
> On Mon, Jun 1, 2026 at 11:35 AM Rosen Penev <rosenp@xxxxxxxxx> wrote:
>>
>> The inline assembly in ep93xx_pata_delay() uses a "subs" instruction
>> which modifies the ARM condition code flags. Add a "cc" clobber so
>> the compiler knows the flags are altered. Without it, the compiler may
>> reorder flag-dependent instructions across the asm block when the
>> function is inlined, potentially causing incorrect control flow.
>>
>> Assisted-by: Opencode:Big-Pickle
>> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> should I resend?

Oops. This fell through the cracks. Yes, please resend and add a fixes tag as well.

--
Damien Le Moal
Western Digital Research