Re: [PATCH v2 1/2] Input: snvs_pwrkey: Improve probe error handling

[Bui Duc Phuc]

Hi Dmitry,

Thank you for your feedback.

> > Use dev_err_probe() for devm_clk_get_optional_enabled() to handle
> > deferred probe correctly.
>
> In what way the does existing code handle deferred probe incorrectly?
>

With the current implementation, dev_err() is still called even when
devm_clk_get_optional_enabled() returns -EPROBE_DEFER.
Since the probe will be retried later anyway, logging an error via dev_err()
causes unnecessary log spam.
Using dev_err_probe() fixes this because under the hood (in
__dev_probe_failed()),
it handles -EPROBE_DEFER using dev_dbg() instead of dev_err():

-----------------------
case -EPROBE_DEFER:
        device_set_deferred_probe_reason(dev, &vaf);
        dev_dbg(dev, "error %pe: %pV", ERR_PTR(err), &vaf);
        break;
----------------------

This avoids log spam while maintaining deferred probe information.

Best regards,
Phuc