Re: Re: [PATCH] base: devcoredump: Replace simple_strtol with kstrtol

[Jiangshan Yi]

> Be careful, we are rejecting ABI changes like this as there is no real
> reason to change this at this point in time, right?
>
> thanks,
>
> greg k-h

Hi Greg,

You're right, thanks for catching this.

The intent was only to drop the obsolete simple_strtol() call. I
didn't properly consider that switching to kstrtol() also tightens
the accepted input for the sysfs store path - e.g. "1<garbage>"
currently parses as 1 and enables lockdown, while with kstrtol() it
would return -EINVAL. That's a userspace-visible behavior change in a
long-stable interface, which isn't justified by just cleaning up an
obsolete helper.

I'll drop this patch.

If on the other hand you'd prefer the stricter behavior as a
deliberate ABI change, I can resend it, but I won't unless you want
it.

thanks,
Jiangshan Yi