Re: [PATCH v2 3/6] ASoC: amd: acp: Use named initializers for platform_device_id arrays

[Mukunda,Vijendar]

On 20/07/26 11:53, Uwe Kleine-König (The Capable Hub) wrote:
> [You don't often get email from u.kleine-koenig@xxxxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Named initializers are better readable and more robust to changes of the
> struct definition. This robustness is relevant for a planned change to
> struct platform_device_id replacing .driver_data by an anonymous union.
>
> While touching these arrays unify spacing and usage of commas.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
Reviewed-by: Vijendar Mukunda <Vijendar.Mukunda@xxxxxxx>
> ---
>  sound/soc/amd/acp/acp-sdw-legacy-mach.c | 4 ++--
>  sound/soc/amd/acp/acp-sdw-sof-mach.c    | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/amd/acp/acp-sdw-legacy-mach.c b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
> index 9726a9d33ec6..637dd2deebfa 100644
> --- a/sound/soc/amd/acp/acp-sdw-legacy-mach.c
> +++ b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
> @@ -580,8 +580,8 @@ static void mc_remove(struct platform_device *pdev)
>  }
>
>  static const struct platform_device_id mc_id_table[] = {
> -       { "amd_sdw", },
> -       {}
> +       { .name = "amd_sdw" },
> +       { }
>  };
>  MODULE_DEVICE_TABLE(platform, mc_id_table);
>
> diff --git a/sound/soc/amd/acp/acp-sdw-sof-mach.c b/sound/soc/amd/acp/acp-sdw-sof-mach.c
> index 963ce6fd4012..8db889d824f6 100644
> --- a/sound/soc/amd/acp/acp-sdw-sof-mach.c
> +++ b/sound/soc/amd/acp/acp-sdw-sof-mach.c
> @@ -438,8 +438,8 @@ static void mc_remove(struct platform_device *pdev)
>  }
>
>  static const struct platform_device_id mc_id_table[] = {
> -       { "amd_sof_sdw", },
> -       {}
> +       { .name = "amd_sof_sdw" },
> +       { }
>  };
>  MODULE_DEVICE_TABLE(platform, mc_id_table);
>
> --
> 2.55.0.11.g153666a7d9bb
>