Re: [PATCH 7/7] soc: xilinx: Remove redundant dev_err()

[Michal Simek]

On 7/20/26 17:50, Pandey, Radhey Shyam wrote:
> On 7/20/2026 3:29 PM, Pan Chuang wrote:
> > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> > devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> > detailed error messages on failure. Remove the now-redundant
> > driver-specific dev_err() calls.
> >
> > Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
> > ---
>
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxx>
> Thanks!
> >   drivers/soc/xilinx/zynqmp_power.c | 5 +----
> >   1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/ 
> > zynqmp_power.c
> > index 370e61ac47d8..54c796afb89e 100644
> > --- a/drivers/soc/xilinx/zynqmp_power.c
> > +++ b/drivers/soc/xilinx/zynqmp_power.c
> > @@ -368,11 +368,8 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
> >                           IRQF_NO_SUSPEND | IRQF_ONESHOT,
> >                           dev_name(&pdev->dev),
> >                           &pdev->dev);
> > -        if (ret) {
> > -            dev_err(&pdev->dev, "devm_request_threaded_irq '%d' failed with 
> > %d\n",
> > -                irq, ret);
> > +        if (ret)
> >               return ret;
> > -        }
> >       } else {
> >           dev_err(&pdev->dev, "Required property not found in DT node\n");
> >           return -ENOENT;

No issue with this patch but how do you want this to be merged?
It should go via soc specific trees and then to Arnd. I don't think Arnd will 
take this directly to soc tree.

My suggestion would be to split it and get that patches merged separately.

Just in case
Acked-by: Michal Simek <michal.simek@xxxxxxx>

Thanks,
Michal