Re: [PATCH v5 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU

[Krzysztof Kozlowski]

On Mon, Jul 13, 2026 at 05:28:14PM +0530, Rakesh Kota wrote:
> PMM8654AU is a distinct PMIC variant from PMM8650AU despite sharing the
> same PMIC subtype. PMM8654AU implements additional registers added to
> the "hlos" register address spaces, so add qcom,pmm8654au-pon as a
> fallback to qcom,pmk8350-pon to distinguish it from the baseline
> PMK8350 PON implementation.
> 
> The GEN3 PON peripheral requires two register address spaces: "hlos"

What is gen3 pon here? It is the first time this appears in the commit
msg.

> for the primary PON block and "pbs" for the address needs to be
> specified to facilitate software debouncing. Set minItems: 2 for reg
> in the qcom,pmk8350-pon if/then constraint to enforce that both
> address spaces are always present.
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> Signed-off-by: Rakesh Kota <rakesh.kota@xxxxxxxxxxxxxxxx>
> ---
> Changes in v5:
>  - Set minItems: 2 for reg in the PMK8350 if/then block to enforce that
>    both hlos and pbs address spaces are required for GEN3 PON peripherals.
> 
> Changes in v4:
>  - Remove the contain for PMK8350 and new if:then for PMM8654AU as
>    suggested by Krzysztof Kozlowski
> 
> Changes in v3:
>  - Update the commit message.
> 
> Changes in v2:
>  - Introduces PMM8654AU compatible strings as suggested by Konrad Dybcio.
> ---
>  .../devicetree/bindings/power/reset/qcom,pon.yaml     | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> index 979a377cb4ffd577bfa51b9a3cd089acc202de0c..09eea48c709e5e42c45c1949ee1d06298dea1f91 100644
> --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> @@ -17,12 +17,16 @@ description: |
>  
>  properties:
>    compatible:
> -    enum:
> -      - qcom,pm8916-pon
> -      - qcom,pm8941-pon
> -      - qcom,pms405-pon
> -      - qcom,pm8998-pon
> -      - qcom,pmk8350-pon
> +    oneOf:
> +      - enum:
> +          - qcom,pm8916-pon
> +          - qcom,pm8941-pon
> +          - qcom,pms405-pon
> +          - qcom,pm8998-pon
> +          - qcom,pmk8350-pon
> +      - items:
> +          - const: qcom,pmm8654au-pon
> +          - const: qcom,pmk8350-pon
>  
>    reg:
>      description: |
> @@ -105,10 +109,9 @@ allOf:
>      then:
>        properties:
>          reg:
> -          minItems: 1
> +          minItems: 2

You wrote that PMM8654AU has additional registers. This implies pmk8350
does not have them, so why are you changing this?

Also, that's an ABI break and I see no relation to the goal of adding
PMM8654AU. Don't combine independent works into one commit.

Best regards,
Krzysztof