Re: [PATCH v6 1/3] ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode

[Krzysztof Kozlowski]

On 21/07/2026 10:14, Mohammad Rafi Shaik wrote:
> 
> 
> On 7/21/2026 12:18 PM, Krzysztof Kozlowski wrote:
>> On Mon, Jul 20, 2026 at 09:32:24PM +0530, Mohammad Rafi Shaik wrote:
>>> +# Digital Audio Interfaces
>>> +patternProperties:
>>> +  '^dai@[0-9a-f]+$':
>>> +    type: object
>>> +    description:
>>> +      Q6DSP Digital Audio Interfaces.
>>> +
>>> +    properties:
>>> +      reg:
>>> +        maxItems: 1
>>> +        description:
>>> +          Digital Audio Interface ID
>>> +
>>> +      clocks:
>>> +        minItems: 1
>>> +        items:
>>> +          - description: MI2S bit clock
>>> +          - description: MI2S external bit clock
>>> +          - description: MI2S master clock
>>> +
>>> +      clock-names:
>>> +        minItems: 1
>>> +        items:
>>> +          - enum: [bclk, eclk, mclk]
>>> +          - const: mclk
>>
>> This does not match your clocks.
>>
> 
> will fix this.
> 
> clocks descriptions are misleading because they imply an
> ordered bclk + eclk configuration. I'll drop those descriptions.
> 
> will keep only
> 
> clocks:
>     minItems: 1
>     maxItems: 2
> 
>> I gave you exact syntax to use, then in previous version you used
>> something else. So I reminded. Again you used something else.
>>
>> If you decide not to use it, sure, your right but YOU CANNOT come with
>> clearly invalid code as a substitute.
>>
>> NAK
> 
> Suggested change: 
> https://lore.kernel.org/all/2b4448d0-81f8-410f-b849-0d957a2d2a17@xxxxxxxxxx/#t
> minItems: 1
> items:
>   - enum: [ bclk, eclk ]
>   - const: eclk
>   - const: mclk
> 
> I tested the suggested schema, but it results in DT binding check failures.
> 
> DT binding check errors with the suggested change
> 1. Only mclk enabled
> bedais: dai@10:clock-names:0: 'mclk' is not one of ['bclk', 'eclk']
> 
> 2. bclk and mclk enabled
> bedais:dai@10:clock-names:1: 'eclk' was expected
> 
> 
> With the current version of this patch, I do not see any DT binding 
> check issues. I tested all supported clock combinations, and 
> dt_binding_check passes successfully in each case.

Your clocks told story that you have up to three clocks, so indeed if
you do not have three clocks then my syntax is not accurate.

Before we go further, where is upstream DTS using this?

Best regards,
Krzysztof