Re: [PATCH v2 1/4] regulator: dt-bindings: Add fan53555 allowed modes

[Krzysztof Kozlowski]

On Mon, Jul 20, 2026 at 12:03:33PM +0200, Victor Krawiec wrote:
> Fairchild FAN53555 and its clone from Rockchip, Silergy and TCS support
> two modes of operation:
> - Auto-PFM: Allow automatic PFM during light load (default mode)
> - Forced PWM
> 
> Some boards require forced PWM mode to keep the supply ripple within
> acceptable limits under light load conditions.
> 
> Regulator mode indexes are starting from 1 to keep backward compatibility
> with existing device trees
> 
> Signed-off-by: Victor Krawiec <victor.krawiec@xxxxxxxxxxx>

SoB here...

> 
> Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml #	new file:
> include/dt-bindings/regulator/fcs,fan53555-regulator.h #
> arch/arm64/boot/dts/rockchip/rk3399-drumfreak.dts #
> arch/arm64/boot/simple-boot.img #	arch/arm64/boot/simple-kernel.img #
> arch/arm64/configs/drumfreak_defconfig #
> scripts/arturia_simple_boot_image.sh #

Looks random paste/mistake...

> 
> Signed-off-by: Victor Krawiec <victor.krawiec@xxxxxxxxxxx>

but also here SoB.

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Best regards,
Krzysztof