Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,milos-pas: Add Eliza CDSP compatible

[Krzysztof Kozlowski]

On 21/07/2026 11:42, Abel Vesa wrote:
> On 26-07-21 11:22:52, Krzysztof Kozlowski wrote:
>> On Tue, Jul 14, 2026 at 03:24:01PM +0300, Abel Vesa wrote:
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          enum:
>>> +            - qcom,eliza-cdsp-pas
>>> +    then:
>>> +      properties:
>>> +        power-domains:
>>> +          items:
>>> +            - description: CX power domain
>>> +            - description: MX power domain
>>> +            - description: NSP power domain
>>> +        power-domain-names:
>>> +          items:
>>> +            - const: cx
>>> +            - const: mx
>>> +            - const: nsp
>>
>> No, do not grow the ifs. Eliza belongs to class of SM8750, so I don't
>> get why it was and it is being added here.
> 
> I'm assuming you meant SM8550 here, right?

The SM8550 binding file, but Eliza is SM8750-based in general thus I
would expect it will be documented along SM8750.

> 
> Why does Eliza belong to SM8750 but Milos doesn't?

I don't know about Milos, but Eliza is variant of SM8750, right?

> 
> Was Milos also a mistake?

This I did not verify.

Best regards,
Krzysztof