Re: [PATCH v17 15/15] arm64: vdso: Expose sigreturn address on vdso to the kernel

[Thomas Weißschuh]

On Tue, Jul 21, 2026 at 05:23:38PM +0800, Jinjie Ruan wrote:
(...)

> >>  arch/arm64/Kconfig                 |  1 +
> >>  arch/arm64/include/asm/elf.h       |  1 +
> >>  arch/arm64/kernel/vdso.c           | 16 ++++++++++++++++
> >>  arch/arm64/kernel/vdso/sigreturn.S |  1 +
> >>  arch/arm64/kernel/vdso/vdso.lds.S  |  1 +
> >>  5 files changed, 20 insertions(+)
> >>
> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> >> index aea686dce3d5..a41d2b593899 100644
> >> --- a/arch/arm64/Kconfig
> >> +++ b/arch/arm64/Kconfig
> >> @@ -86,6 +86,7 @@ config ARM64
> >>  	select ARCH_SUPPORTS_SCHED_SMT
> >>  	select ARCH_SUPPORTS_SCHED_CLUSTER
> >>  	select ARCH_SUPPORTS_SCHED_MC
> >> +	select ARCH_SUPPORTS_SYSCALL_USER_DISPATCH
> > 
> > From the subject and description I would not have expected this to be in here.
> > Split into its own patch?
> 
> If ARCH_SUPPORTS_SYSCALL_USER_DISPATCH is not implemented, then it seems
> pointless to implement arch_syscall_is_vdso_sigreturn() separately,

Absolutely. Although a preparatory patch can introduce infrastructure like this.

> or perhaps we should revise the title to indicate support for SUD on arm64?

That works, too.

> >>  	select ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH
> >>  	select ARCH_WANT_COMPAT_IPC_PARSE_VERSION if COMPAT
> >>  	select ARCH_WANT_DEFAULT_BPF_JIT
> > 
> > (...)
> > 
> > For the rest:
> > 
> > Reviewed-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> 
> Thanks for the review.

You're welcome!

Just to make it clear: This is only for this patch, not the whole series.


Thomas