Re: [PATCH net-next 4/5] net: phy: mediatek: add calibration logic for AN7581

[Paolo Abeni]

On 7/8/26 12:23 PM, Christian Marangi wrote:
> +static int airoha_cal_cycle(struct phy_device *phydev, int devad,
> +			    u32 regnum, u16 mask, u16 cal_val)
> +{
> +	struct airoha_socphy_shared *shared = phy_package_get_priv(phydev);
> +	struct phy_device *phydev_p0;
> +	int ret;
> +
> +	phydev_p0 = shared->phydev_p0;
> +
> +	phy_modify_mmd(phydev, devad, regnum, mask, cal_val);
> +
> +	ret = mtk_cal_cycle_wait(phydev_p0);

The above call causes a builder error at link time in allmodyes config:

ERROR: modpost: "mtk_cal_cycle_wait"
[drivers/net/phy/mediatek/airoha-ge-soc.ko] undefined!

Also sashiko gemini has a few points:

https://sashiko.dev/#/patchset/20260708102341.53919-1-ansuelsmth%40gmail.com

/P