Re: [PATCH v2 5/6] riscv: dts: spacemit: Add K3 I2C6 pinctrl state

From: Troy Mitchell

Date: Tue Jul 21 2026 - 07:57:09 EST


On Tue, Jul 21, 2026 at 10:00:38AM +0000, sashiko-bot@xxxxxxxxxx wrote:
> [Severity: Low]
> Is this drive-strength value supported by the binding? The value 18
> doesn't appear to be valid according to the SpacemiT K3 pinctrl binding
> schema (spacemit,k1-pinctrl.yaml), which triggers a dtbs_check validation
> failure.
>
> Since the driver's spacemit_get_ds_value() will silently fall back to the
> next highest valid value (like 21mA or 25mA depending on voltage), could
> this cause an unexpected mismatch between the requested devicetree state
> and the actual hardware configuration?

Good catch. This pin group uses the 3.3 V power domain, for which 18 mA is
not a valid K3 drive-strength value. The driver rounds that request up to
25 mA, so I will use 25 mA in the devicetree to describe the configuration
that is actually programmed and to satisfy the binding.

- Troy