Re: Missing signoff in the kvm-arm-fixes tree
From: Marc Zyngier
Date: Tue Jul 21 2026 - 08:10:28 EST
On Tue, 21 Jul 2026 12:46:11 +0100,
Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> [1 <text/plain; us-ascii (7bit)>]
> Commit
>
> 6c13643a6f392 ("KVM: arm64: Fix hyp_trace clock disabling")
>
> is missing a Signed-off-by from its committer
Amusing:
maz@valley-girl:~/hot-poop/arm-platforms$ b4 am -lsto - 20260715105100.3178255-1-vdonnefort@xxxxxxxxxx | git am
Grabbing thread from lore.kernel.org/all/20260715105100.3178255-1-vdonnefort@xxxxxxxxxx/t.mbox.gz
Analyzing 4 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Analyzing 0 code-review messages
Checking attestation on all messages, may take a moment...
---
✓ [PATCH v2] KVM: arm64: Fix hyp_trace clock disabling
+ Reviewed-by: Fuad Tabba <fuad.tabba@xxxxxxxxx> (✓ DKIM/linux.dev)
+ Link: https://patch.msgid.link/20260715105100.3178255-1-vdonnefort@xxxxxxxxxx
+ Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
---
✓ Signed: DKIM/google.com
---
Total patches: 1
---
Link: https://patch.msgid.link/20260715105100.3178255-1-vdonnefort@xxxxxxxxxx
Base: using specified base-commit a13c140cc289c0b7b3770bce5b3ad42ab35074aa
git checkout -b v2_20260715_vdonnefort_google_com a13c140cc289c0b7b3770bce5b3ad42ab35074aa
Applying: KVM: arm64: Fix hyp_trace clock disabling
maz@valley-girl:~/hot-poop/arm-platforms$ git show
commit ffb57162cb4e20971ea41320f8dd9fad7d141e9f (HEAD)
Author: Vincent Donnefort <vdonnefort@xxxxxxxxxx>
Date: Wed Jul 15 11:51:00 2026 +0100
KVM: arm64: Fix hyp_trace clock disabling
Fix the disable path in hyp_trace_clock_enable(), which fell through to
re-initialize and reschedule the clock after cancelling the work. Return
early instead.
While at it, cleanup hyp_trace_clock::lock which is unused and
hyp_trace_clock::running which is redundant: the trace_remote framework
already serializes calls to the callback enable_tracing.
Fixes: b22888917fa4 ("KVM: arm64: Sync boot clock with the nVHE/pKVM hyp")
Signed-off-by: Vincent Donnefort <vdonnefort@xxxxxxxxxx>
No RB, no SoB, no Link. Guess b4 is busted in some way...
BTW, could you please Cc the actual maintainers of KVM/arm64?
Christoffer has been out of that look for over 7 years now...
Thanks,
M.
--
Without deviation from the norm, progress is not possible.