Re: [PATCH v2 2/3] arm64: dts: qcom: qrb2210: fix PM4125 regulator supply parent mappings

[Dmitry Baryshkov]

On Mon, Jul 20, 2026 at 04:25:05PM +0530, Rakesh Kota wrote:
> The qrb2210-arduino-imola and qrb2210-rb1 DTS files used coarsely
> grouped supply parent names that do not reflect the actual physical
> pin connections on the PM4125 PMIC. Since supply rail connections
> to PMIC pins are fixed in hardware, these grouped names were
> inaccurate descriptions of the hardware topology.
> 
> Replace them with the correct per-group supply properties matching
> the actual PM4125 pin connections, and align with the companion
> driver change that sets supply names to NULL in the qcom_smd-regulator
> descriptor so that the correct supply topology is captured in DT.

Two separate commits, each having a proper Fixes tag.

> 
> Signed-off-by: Rakesh Kota <rakesh.kota@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts | 13 ++++++++++---
>  arch/arm64/boot/dts/qcom/qrb2210-rb1.dts           | 13 ++++++++++---
>  2 files changed, 20 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> index c472e13fceca..90e6eb284a66 100644
> --- a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> @@ -262,9 +262,16 @@ regulators {
>  		compatible = "qcom,rpm-pm2250-regulators";
>  		vdd_s3-supply = <&vph_pwr>;
>  		vdd_s4-supply = <&vph_pwr>;
> -		vdd_l1_l2_l3_l5_l6_l7_l8_l9_l10_l11_l12-supply = <&pm4125_s3>;
> -		vdd_l4_l17_l18_l19_l20_l21_l22-supply = <&vph_pwr>;
> -		vdd_l13_l14_l15_l16-supply = <&pm4125_s4>;
> +		vdd_l1-supply =  <&pm4125_s3>;
> +		vdd_l2_l3-supply =  <&pm4125_s3>;
> +		vdd_l5_l6_l7_l11_l12-supply =  <&pm4125_s3>;
> +		vdd_l8_l9-supply =  <&pm4125_s3>;
> +		vdd_l10-supply =  <&pm4125_s3>;
> +		vdd_l13_l14-supply =  <&pm4125_s4>;
> +		vdd_l15_l16-supply =  <&pm4125_s4>;
> +		vdd_l17_l22-supply = <&vph_pwr>;
> +		vdd_l18_l19-supply = <&vph_pwr>;
> +		vdd_l4_l20_l21-supply = <&vph_pwr>;
>  
>  		pm4125_s3: s3 {
>  			/* 0.4V-1.6625V -> 1.3V (Power tree requirements) */
> diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
> index bf6fb12ad990..3432022274d8 100644
> --- a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
> @@ -465,9 +465,16 @@ regulators {
>  		compatible = "qcom,rpm-pm2250-regulators";
>  		vdd_s3-supply = <&vph_pwr>;
>  		vdd_s4-supply = <&vph_pwr>;
> -		vdd_l1_l2_l3_l5_l6_l7_l8_l9_l10_l11_l12-supply = <&pm4125_s3>;
> -		vdd_l4_l17_l18_l19_l20_l21_l22-supply = <&vph_pwr>;
> -		vdd_l13_l14_l15_l16-supply = <&pm4125_s4>;
> +		vdd_l1-supply =  <&pm4125_s3>;
> +		vdd_l2_l3-supply =  <&pm4125_s3>;
> +		vdd_l5_l6_l7_l11_l12-supply =  <&pm4125_s3>;
> +		vdd_l8_l9-supply =  <&pm4125_s3>;
> +		vdd_l10-supply =  <&pm4125_s3>;
> +		vdd_l13_l14-supply =  <&pm4125_s4>;
> +		vdd_l15_l16-supply =  <&pm4125_s4>;
> +		vdd_l17_l22-supply = <&vph_pwr>;
> +		vdd_l18_l19-supply = <&vph_pwr>;
> +		vdd_l4_l20_l21-supply = <&vph_pwr>;
>  
>  		/*
>  		 * S1 - VDD_APC
> 
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry