Re: [PATCH net-next v5] net: phy: Add driver for Motorcomm Quad 2.5GbE phy

[Andrew Lunn]

> +#define YT8824_UTP_TEMPLATE_MODE_CTRL		(0x84)
> +#define YT8824_UTP_TEMPLATE_MODE_MASK		GENMASK(15, 13)
> +#define YT8824_UTP_TEMPLATE_TEST_MODE1		BIT(13)

Is this MultiGBASE-T test mode register (Register 1.132)?

The test mode control is not a single bit, but three bits. So you
should not be using BIT(13).

Since this is a standard part of C45, please add a helper to phy-c45.c

Another thing i want to take a look at is the locking. It is pretty
ugly having to use so many __ functions, and not being able to use the
helpers. I want to see if we can avoid this.

    Andrew

---
pw-bot: cr